svn commit: r396689 - in head/mail: cyrus-imapd23 cyrus-imapd24 cyrus-imapd25

Alexey Dokuchaev danfe at FreeBSD.org
Sat Sep 12 15:29:45 UTC 2015


On Sat, Sep 12, 2015 at 11:46:13PM +0900, Hajimu UMEMOTO wrote:
> Then, I'll back them out by myself, sigh.  It is hard to inspect
> whether it becomes equivalent to the one I intended.  You could make
> me be disappointed at your effort.

Umemoto-san,

While those changes do look hard to get/comprehend at the first sight
(I had to suffer from similar commits in the past), I don't think there
is need for a backout.  You might try to back it out piece by piece in
your local working copy and review until you have an "aha!" moment and
move to the next one.

Chances are it's not really that bad after all.  The framework got much
smarter, people are getting used to it, and old-school code (very nice,
perfectly working) will just urge people's itch.

./danfe


More information about the svn-ports-all mailing list