svn commit: r396554 - in head/devel/liblouis: . files

Thu Sep 10 18:30:13 UTC 2015

Not new in this version but you may need to add

  BUILD_DEPENDS=	help2man:${PORTSDIR}/misc/help2man

and populate pkg-plist due to

  $ make check-plist
  ====> Checking for pkg-plist issues (check-plist)
  ===> Parsing plist
  ===> Checking for items in STAGEDIR missing from pkg-plist
  Error: Orphaned: man/man1/lou_allround.1.gz
  Error: Orphaned: man/man1/lou_checkhyphens.1.gz
  Error: Orphaned: man/man1/lou_checktable.1.gz
  Error: Orphaned: man/man1/lou_debug.1.gz
  Error: Orphaned: man/man1/lou_trace.1.gz
  Error: Orphaned: man/man1/lou_translate.1.gz
  ===> Checking for items in pkg-plist which are not in STAGEDIR
  ===> Error: Plist issues found.
  *** Error code 1

And LICENSE seems bogus as ${WRKSRC}/liblouis/*.c have:

   This file is free software; you can redistribute it and/or modify it
   under the terms of the Lesser or Library GNU General Public License 
   as published by the
   Free Software Foundation; either version 3, or (at your option) any
   later version.

Wen Heping <wen at FreeBSD.org> writes:

> -USES=		gmake libtool
> +USES=		gmake libtool autoreconf
[...]
> +pre-configure:
> +	cd ${WRKSRC} && ./autogen.sh
>  

USES=autoreconf already runs autotools during configure stage. If you
only need its build dependencies do USES=autoreconf:build.

However, the only difference between autogen.sh and USES=autoreconf is
the clean up of working directory. The step is not necessary for a
freshly extracted tarball.

Also, sort USES to pet portlint.

>  OPTIONS_DEFINE=	DOCS
[...]
> -	@${MKDIR} ${STAGEDIR}${DOCSDIR}
> -.for i in liblouis.html liblouis.txt
> -	${INSTALL_MAN} ${WRKSRC}/doc/${i} ${STAGEDIR}${DOCSDIR}
> -.endfor
[...]
> -%%PORTDOCS%%%%DOCSDIR%%/liblouis.html
> -%%PORTDOCS%%%%DOCSDIR%%/liblouis.txt

Why OPTIONS_DEFINE=DOCS was left out of the removal?

> +	${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/liblouis.so

Why not INSTALL_TARGET=install-strip? It's always available in the
projects using automake i.e., a subset of ports with GNU_CONFIGURE.

> -libdata/pkgconfig/liblouis.pc
> +lib/pkgconfig/liblouis.pc

For a reason likely lost[1] in time devel/pkg-config and devel/pkgconf
use libdata/pkgconfig by default. As such using vendor defaults isn't
going to work with FreeBSD ports. Please, convert to

  USES=		... pathfix
  PATHFIX_MAKEFILEIN=	Makefile.am

portlint -C should have warned you about this!

> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/liblouis/files/patch-autogen.sh	Thu Sep 10 08:46:47 2015	(r396554)
> @@ -0,0 +1,13 @@
> +--- autogen.sh.orig	2015-09-10 16:17:51.726491000 +0800
> ++++ autogen.sh	2015-09-10 16:18:08.800813000 +0800

Please, keep new patches in |make makepatch| format. It puts the date of
the last *vendor* modification correctly.

--
[1] Probably to mimic hier(7) but base distinction for lib and libdata
    have also eroded:

      /usr/lib/debug (from WITH_DEBUG_FILES)

      /usr/libdata/ldscripts
      /usr/lib/dtrace

      /usr/libdata/gcc
      /usr/lib/clang (on 11.0C)
      /usr/include/gcc
      /usr/include/clang (before 11.0C)

Index: devel/liblouis/Makefile
===================================================================

--- devel/liblouis/Makefile	(revision 396571)
+++ devel/liblouis/Makefile	(working copy)
@@ -9,19 +9,15 @@ CATEGORIES=	devel
 MAINTAINER=	wen at FreeBSD.org
 COMMENT=	Open-source Braille Translator And Back-translator
 
-LICENSE=	GPLv3
+LICENSE=	LGPL3 # or any later version
 
-OPTIONS_DEFINE=	DOCS
+BUILD_DEPENDS=	help2man:${PORTSDIR}/misc/help2man
 
-USES=		gmake libtool autoreconf
+USES=		autoreconf gmake libtool pathfix
 USE_GITHUB=	yes
 GNU_CONFIGURE=	yes
 USE_LDCONFIG=	yes
+PATHFIX_MAKEFILEIN=	Makefile.am
+INSTALL_TARGET=	install-strip
 
-pre-configure:
-	cd ${WRKSRC} && ./autogen.sh
-
-post-install:
-	${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/liblouis.so
-
 .include <bsd.port.mk>
Index: devel/liblouis/files/patch-autogen.sh
===================================================================
--- devel/liblouis/files/patch-autogen.sh	(revision 396571)
+++ devel/liblouis/files/patch-autogen.sh	(working copy)
@@ -1,13 +0,0 @@
---- autogen.sh.orig	2015-09-10 16:17:51.726491000 +0800
-+++ autogen.sh	2015-09-10 16:18:08.800813000 +0800
-@@ -28,8 +28,8 @@
- 
- # Refresh GNU autotools toolchain.
- echo Cleaning autotools files...
--find -type d -name autom4te.cache -print0 | xargs -0 rm -rf \;
--find -type f \( -name missing -o -name install-sh -o -name mkinstalldirs \
-+find . -type d -name autom4te.cache -print0 | xargs -0 rm -rf \;
-+find . -type f \( -name missing -o -name install-sh -o -name mkinstalldirs \
- 	-o -name depcomp -o -name ltmain.sh -o -name configure \
- 	-o -name config.sub -o -name config.guess -o -name config.h.in \
-         -o -name mdate-sh -o -name texinfo.tex \
Index: devel/liblouis/pkg-plist
===================================================================
--- devel/liblouis/pkg-plist	(revision 396571)
+++ devel/liblouis/pkg-plist	(working copy)
@@ -11,7 +11,13 @@ lib/liblouis.a
 lib/liblouis.so
 lib/liblouis.so.9
 lib/liblouis.so.9.0.0
-lib/pkgconfig/liblouis.pc
+libdata/pkgconfig/liblouis.pc
+man/man1/lou_allround.1.gz
+man/man1/lou_checkhyphens.1.gz
+man/man1/lou_checktable.1.gz
+man/man1/lou_debug.1.gz
+man/man1/lou_trace.1.gz
+man/man1/lou_translate.1.gz
 %%DATADIR%%/tables/Cz-Cz-g1.utb
 %%DATADIR%%/tables/Es-Es-G0.utb
 %%DATADIR%%/tables/Es-Es-g1.utb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 602 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150910/b734f299/attachment.bin>
