svn commit: r396547 - in head/textproc: . smi

[Philip M. Gollucci]

Well gosh.  I must not approve things while crszy.

Thanks Jan!

On Wednesday, September 9, 2015, Jan Beich <jbeich at freebsd.org> wrote:

> Jason Unovitch <junovitch at FreeBSD.org> writes:
>
> > +post-patch:
> > +     ${REINPLACE_CMD} -e 's|^CC = .*|CC = ${CC}|' \
>
> CC is defined by default to a sane value in both GNU and BSD make.
> One can do '/^CC/d' but see below for better way.
>
> > +                      -e 's|^PREFIX = .*|PREFlX = ${PREFIX}|' \
>                                                ^^^
> Typo: l .vs I. It still works because PREFIX is also passed via MAKE_ENV.
>
> > +                      -e 's|^MANPREFIX = .*|MANPREFIX = ${MANPREFIX}|' \
> > +                      ${WRKSRC}/config.mk
>
> If possible try to avoid patching makefiles if overriding a few
> variables is enough. For one, your entire post-patch can be:
>
>   MAKE_ARGS=    CC="${CC}" PREFIX="${PREFIX}" MANPREFIX="${MANPREFIX}"
>


-- 
---------------------------------------------------------------------------------
Curb: Your ride is here
4096R/D21D2752
<http://pgp.mit.edu/pks/lookup?op=get&search=0xF699A450D21D2752> ECDF B597
B54B 7F92 753E  E0EA F699 A450 D21D 2752
Philip M. Gollucci (pgollucci at p6m7g8.com) c: 703.336.9354
Member,                           Apache Software Foundation
Committer,                        FreeBSD Foundation
Consultant,                       P6M7G8 Inc.
Sr. Director IT Operations,       Curb

What doesn't kill us can only make us stronger;
Except it almost kills you.