svn commit: r396521 - in head/lang/mosh: . files

[Jan Beich]

Alexey Dokuchaev <danfe at FreeBSD.org> writes:

>   - Propagate available SIMD support down to the compiler (x86 only)
[...]
> +.if ${MACHINE_CPU:Msse3}
> +CONFIGURE_ENV+=	MOSH_OPTS="-msse3 -mfpmath=sse"
> +.elif ${MACHINE_CPU:Msse2}
> +CONFIGURE_ENV+=	MOSH_OPTS="-msse2 -mfpmath=sse"
> +.elif ${MACHINE_CPU:Msse}
> +CONFIGURE_ENV+=	MOSH_OPTS="-msse -mfpmath=sse"
> +.elif ${MACHINE_CPU:Mmmx}
> +CONFIGURE_ENV+=	MOSH_OPTS="-mmmx"
>  .endif

Why add cargo cult optimization? Nothing in i?86 code seems to rely on
__SSE* defines or *intrin.h. Besides, -mfpmath=sse, -msse2 and -msse are
default on amd64 which means the following chunk is always enabled:

  // extlibs/gc-cvs/libatomic_ops/src/atomic_ops/sysdeps/standard_ao_double_t.h
  #if (defined(__x86_64__) && defined(__GNUC__)) || defined(_WIN64)
  # include <xmmintrin.h>
    typedef __m128 double_ptr_storage;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 602 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150909/b3e2c532/attachment.bin>