svn commit: r394508 - in head: . Mk Tools/scripts audio/amarok-kde4 audio/jack audio/lua51-mpd audio/py-mpd2 biology/ruby-bio chinese/joe chinese/phpbb3-tw databases/jdbm2 databases/luasql-mysql da...

[Baptiste Daroussin]

On Thu, Sep 03, 2015 at 04:54:48PM -0700, Bryan Drewery wrote:
> On 8/17/15 7:20 AM, Mathieu Arnold wrote:
> > Author: mat
> > Date: Mon Aug 17 14:20:40 2015
> > New Revision: 394508
> > URL: https://svnweb.freebsd.org/changeset/ports/394508
> > 
> > Log:
> >   Remove UNIQUENAME and LATEST_LINK.
> >   
> >   UNIQUENAME was never unique, it was only used by USE_LDCONFIG and now,
> >   we won't have conflicts there.
> >   
> >   Use PKGBASE instead of LATEST_LINK in PKGLATESTFILE, the *only* consumer
> >   is pkg-devel, and it works just fine without LATEST_LINK as pkg-devel
> >   has the correct PKGNAME anyway.
> >   
> >   Now that UNIQUENAME is gone, OPTIONSFILE is too. (it's been called
> >   OPTIONS_FILE now.)
> 
> Please restore handling for OPTIONSFILE. It was there for backwards
> compat and now breaks POLA.
> 
> I had options in a OPTIONSFILE that unset things that now are coming back.
> 
> For example I have a /var/db/ports/gpgme/options that had
> OPTIONS_UNSET+= UISERVER, but I have no
> /var/db/ports/security_gpgme/options. So now I get the defaults.
> 
This is weird because the ports tree should have automatically moved those to
security_gpgme during the last years except if set using poudriere options
/me hates poudriere options :)

Maybe poudriere should check the sanity of the options dir when running but that
is another subject.

That said I agree that 2 things should be restored: OPTIONSFILE= and the
<name>_SET

But we should absolutely not readd UNIQUENAME, so both should be based on
PKGBASE.

If OPTIONSILE is found a warning should be send to the users. with a deprecation
notice.

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150904/f890bd85/attachment.bin>