svn commit: r398482 - head/devel/py-greenlet

[Dmitry Marakasov]

* Kubilay Kocak (koobs at FreeBSD.org) wrote:

> > Author: sunpoet
> > Date: Sat Oct  3 17:07:29 2015
> > New Revision: 398482
> > URL: https://svnweb.freebsd.org/changeset/ports/398482
> > 
> > Log:
> >   - Convert to new test framework
> > 
> > Modified:
> >   head/devel/py-greenlet/Makefile
> > 
> > Modified: head/devel/py-greenlet/Makefile
> > ==============================================================================
> > --- head/devel/py-greenlet/Makefile	Sat Oct  3 17:07:24 2015	(r398481)
> > +++ head/devel/py-greenlet/Makefile	Sat Oct  3 17:07:29 2015	(r398482)
> > @@ -12,14 +12,13 @@ COMMENT=	Light-weight microthreads for P
> >  
> >  LICENSE=	MIT
> >  
> > +DO_MAKE_TEST=	${PYTHON_CMD}
> 
> This is horrible & super ugly.

I agree. Using variables in such a quirky and unintended way is
incomprehensible for people reading port Makefiles and tend to
break easily on framework changes.

> Why can't we have / isn't there a TEST_CMD variable to complement
> TEST_{ARGS,DEPENDS,*} variables?

I don't see a reason for this - it'll not cover all cases and it's a
pain to understand. We don't have BUILD_CMD and INSTALL_CMD either.

This is obvious case where do-test: should be used.

> The new test framework is VERY VERY welcome, but I'm worried it needs
> polishing/refinement for extensibility across the broader ports
> framework *before* a large number of ports have been 'converted',
> thereby cementing in an under-baked implementation and making it much
> harder to change for the better.
> 
> Another worry is that there isn't an *explicit* opt-in or toggle to
> enable tests.

As I've stated several times already, there's an opt-out and it's the
way it should be. It's not like broken test break user or package
builds, though for test-aware environments (like users runing tests or
q/a poudriere) all tests should always be visible. And all failures
should be taken care of.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3 at amdmi3.ru  ..:  jabber: amdmi3 at jabber.ru      http://amdmi3.ru