svn commit: r389861 - in head/devel: cmake cmake-gui cmake-modules

[Steve Wills]

On Wed, Jun 17, 2015 at 09:39:11AM -0600, Adam Weinberger wrote:
> > On 16 Jun, 2015, at 14:25, Brad Davis <brd at FreeBSD.org> wrote:
> > 
> > Author: brd
> > Date: Tue Jun 16 20:25:05 2015
> > New Revision: 389861
> > URL: https://svnweb.freebsd.org/changeset/ports/389861
> > 
> > Log:
> >  Update devel/cmake, devel/cmake-gui and devel/cmake-modules to 3.2.3.
> > 
> > Modified: head/devel/cmake/Makefile
> > ==============================================================================
> > 
> > LIB_DEPENDS=	libcurl.so:${PORTSDIR}/ftp/curl \
> > -		libexpat.so:${PORTSDIR}/textproc/expat2
> > +		libexpat.so:${PORTSDIR}/textproc/expat2 \
> > +		libjsoncpp.so:${PORTSDIR}/devel/jsoncpp
> 
> Does this port really need to depend on libjsoncpp? The version bundled with cmake works just fine (--no-system-jsoncpp).
> 
> The only benefit to making everybody install jsoncpp (and scons) would be if the jsoncpp port is updated more often than the cmake port. But the jsoncpp port hasn't had an update since the day it was added 16 months ago.
> 
> Can you please consider dropping the libjsoncpp dependency and just adding --no-system-jsoncpp to CONFIGURE_ARGS?
> 

In general, it is better to not used bundled libs where possible. Let's update
the devel/jsoncpp port.

Steve