svn commit: r393097 - in head/graphics: gphoto2 gphoto2/files libgphoto2 libgphoto2/files
Guido Falsi
madpilot at FreeBSD.org
Wed Jul 29 07:49:27 UTC 2015
On 07/29/15 09:10, Alexey Dokuchaev wrote:
> On Tue, Jul 28, 2015 at 08:12:46PM +0000, Guido Falsi wrote:
>> New Revision: 393097
>> URL: https://svnweb.freebsd.org/changeset/ports/393097
>>
>> Log:
>> Update to 2.5.8
>>
>> PR: 201845
>> Submitted by: tkato432 at yahoo.com
>
> Guys,
>
> Bear in mind that Kato's PRs often come with noise in the patches that
> should not be committed. Always review their submission thoroughly.
I did, but this time some details slipped by me.
>
>> @@ -10,6 +10,7 @@ MAINTAINER= ports at FreeBSD.org
>> COMMENT= Command-line frontend to libgphoto2
>>
>> LICENSE= GPLv2
>> +#LICENSE_FILE= ${WRKSRC}/COPYING
>
> What was that supposed to mean, I wonder? :)
I had seen it, but since it causes no harm I thought it could stay. My
understanding is that LICENSE_FILE should be specified only if the
relevant file differs from the standard license. I would have removed
the line, but a commented line isn't a big deal. Anyway I'll clean this up.
>
>> post-install:
>> - ${INSTALL_DATA} ${WRKSRC}/NEWS ${STAGEDIR}${DOCSDIR}
>> + (cd ${WRKSRC} && ${INSTALL_DATA} NEWS ${STAGEDIR}${DOCSDIR})
>
> What this change was supposed to improve? It's longer, it now takes two
> commands instead of one, it requires grouping, etc. So how did it pass
> the review and got committed?
Oops, my fault, I did read it but I elaborated it like it was a
"COPYTREE", where the cd is actually needed.
Thanks for pointing this one out.
--
Guido Falsi <madpilot at FreeBSD.org>
More information about the svn-ports-all
mailing list