svn commit: r392666 - head/audio/libgroove

[John Marino]

On 7/22/2015 3:32 PM, Pietro Cerutti wrote:
> On 2015-07-22 15:29, John Marino wrote:
>> On 7/22/2015 2:44 PM, Pietro Cerutti wrote:
>>> On 2015-07-22 14:25, Alexey Dokuchaev wrote:
>>> In clear contrast with the PHB, which states "If this line is present,
>>> future maintainers must
>>> not change or remove it except at the original author's request."
>>>
>>> It does *not* say "Future maintainers can change it if not explicitly
>>> asked not to.".
>>>
>>> Look, we do have rules so we don't have to argue about taste, style,
>>> what's more sensible to you, etc.
>>>
>>>> Sorry I forgot to ask: so any problem with expansion?
>>>
>>> Yes, I do. Please revert.
>>>
>>
>> So reverting it obviously goes against current practice.  Is the
>> "problem" one of principle?  In other words, are you torqued because
>> danfe touched the makefile, so you want him to revert it regardless of
>> the commit itself?  From afar, this appears like you are trying to make
>> a point at the expense of the ports tree.
> 
> I never meant to revert the whole commit, sorry for the wording. Does
> 'please get back the "Created by" line as it was before' sound ok?

I knew that's what you meant, and that's what I'm talking about.  The
expanded name is the defacto standard and this was hammered into me
during mentering.  You're going out of your way to go against this
without explaining why, so I'm curious as to why.  Danfe just didn't
make this up.

John