svn commit: r392666 - head/audio/libgroove

Alexey Dokuchaev danfe at FreeBSD.org
Wed Jul 22 12:23:13 UTC 2015


On Wed, Jul 22, 2015 at 01:49:37PM +0200, Pietro Cerutti wrote:
> > @@ -1,29 +1,29 @@
> > -# Created by: gahr
> > +# Created by: Pietro Cerutti <gahr at FreeBSD.org>
> 
> I would have appreciated you notifying me of such change.
> Is this modification really needed?

It's obviously not *really* needed as it touches Makefile header, thus being
non-functional.  On on the other hand, we're not forbidding non-functional
changes, right? :)

I try to keep these tags consistent across committers and people without
freefall login for a number of reasons, and first + last names with and
email in angle brackets makes it look neat and standard.  It's a bit sad
that we did not advertise this form through the PHB since the beginning.

> Are you going to change all similar occurrences in the ports tree?

I won't convert them in bulk, most certainly.  I do expand them when I
notice one (and was not asked to leave that/those particular one alone).

./danfe


More information about the svn-ports-all mailing list