svn commit: r392209 - in head/devel: . p5-Minilla

[Baptiste Daroussin]

On Thu, Jul 16, 2015 at 11:10:22AM +0200, Baptiste Daroussin wrote:
> On Thu, Jul 16, 2015 at 01:43:06AM +0000, Alexey Dokuchaev wrote:
> > On Wed, Jul 15, 2015 at 10:38:33PM +0200, Mathieu Arnold wrote:
> > > +--On 15 juillet 2015 20:17:14 +0000 Dmitry Marakasov <amdmi3 at FreeBSD.org>
> > > wrote:
> > > 
> > > | +RUN_DEPENDS:=	${BUILD_DEPENDS}
> > > 
> > > Please, do *not* use := for depends, it is wrong.
> > > <https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html>
> > 
> > Can you clarify on what is wrong with := ?  I've added IMHO quite clear and
> > elaborate explanation in the PH on the matter, and I don't see the merit of
> > using MY_DEPENDS at all: it's ugly, it's hard to read, it pollutes namespace
> > for no sound reason.
> > 
> > People should learn their tools instead of inventing obscure workarounds.
> > 
> := enforce the expansion to happen right away
> 
> Let's say you have:
> 
> RUN_DEPENDS=	${BLOODYSCRIPTLANGUAGEPREFIX}bal>0:${PORTSDIR}/somewhere/bla
> BULID_DEPENDS:=	${RUN_DEPENDS}
> 
> .include <bsd.port.mk>
> 
> 
> BULID_DEPENDS will magically have ${BLOODYSCRIPTLANGUAGEPREFIX} expanded to ""
> because it is not yet defined at the moment the expansion is requested.

Well my example is bad here because undefined variable will be expanded later,
but I think you got the point about inconsistency of the expansion with := and
look at the svn history I have fixed a couple of weird issues we hard in the
ports tree due do weirdness of how := do the expansion.

I prefer a sane (yet ugly) constuction that consistently works the same over the
portstree than I constuction which can bite contributors and get quite complex
to debug.

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150716/90279384/attachment.bin>