svn commit: r391626 - head/games/warzone2100

[Dmitry Marakasov]

* John Marino (freebsd.contact at marino.st) wrote:

> >>> Author: amdmi3
> >>> Date: Thu Jul  9 09:44:51 2015
> >>> New Revision: 391626
> >>> URL: https://svnweb.freebsd.org/changeset/ports/391626
> >>>
> >>> Log:
> >>>   - Remove unncecessary full path to binary from *_DEPENDS
> >>>
> >>> Modified:
> >>>   head/games/warzone2100/Makefile
> >>>
> >>> Modified: head/games/warzone2100/Makefile
> >>> ==============================================================================
> >>> --- head/games/warzone2100/Makefile	Thu Jul  9 09:44:33 2015	(r391625)
> >>> +++ head/games/warzone2100/Makefile	Thu Jul  9 09:44:51 2015	(r391626)
> >>> @@ -13,7 +13,7 @@ LICENSE_FILE=	${WRKSRC}/COPYING
> >>>  
> >>>  BUILD_DEPENDS=	zip:${PORTSDIR}/archivers/zip \
> >>>  		unzip:${PORTSDIR}/archivers/unzip \
> >>> -		${LOCALBASE}/bin/flex:${PORTSDIR}/textproc/flex
> >>> +		flex:${PORTSDIR}/textproc/flex
> >>>  LIB_DEPENDS=	libphysfs.so:${PORTSDIR}/devel/physfs \
> >>>  		libpng.so:${PORTSDIR}/graphics/png \
> >>>  		libvorbis.so:${PORTSDIR}/audio/libvorbis \
> >>>
> >>
> >> This could be a mistake.
> >> This changes depends from /usr/local/bin/flex to /usr/bin/flex.
> >> Are you sure that's what you want to do?
> > 
> > As I understand, that's why binary names are preferred: as there's
> > /usr/bin/flex, unneeded dependency won't be installed. However, that
> > seem to be an artifact from 6.x days, and this dependency is not needed
> > at all, all supported FreeBSD releases have flex in base system.
> > 
> 
> My understanding is that you created a dependency specification that is
> only accidently satisfied.  You asked textproc/flex to be installed, but
> then check /usr/bin/flex from that package (which is not inside).
> 
> Flex is notorious.  If flex is specified in BUILD_DEPENDS, then 100% of
> the time, you really, really want /usr/local/bin/flex.  If /usr/bin/flex
> works, then you would not put it in BUILD_DEPENDS.  /usr/bin/flex is
> available on all releases so if it works as you say, then textproc/flex
> will never get pulled in.
> 
> My guess is that if textproc/flex is listed here, then it's needed over
> the base flex.  Thus, I think the change is an error.

Like I've already said, the dependency is absolutely correct and does what
it should. It's a no-op though on all supported FreeBSD versions,
so I'm removing it.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3 at amdmi3.ru  ..:  jabber: amdmi3 at jabber.ru      http://amdmi3.ru