svn commit: r377495 - head/textproc/py-pygments

[Adam Weinberger]

> On Jan 20, 2015, at 01:28, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
> 
>> On Tue, Jan 20, 2015 at 09:17:24AM +0100, John Marino wrote:
>>> On 1/20/2015 09:12, Alexey Dokuchaev wrote:
>>>> On Tue, Jan 20, 2015 at 04:12:31AM +0000, Adam Weinberger wrote:
>>>> New Revision: 377495
>>>> URL: https://svnweb.freebsd.org/changeset/ports/377495
>>>> QAT: https://qat.redports.org/buildarchive/r377495/
>>>> 
>>>> Log:
>>>>  Update to 2.0.1.
>>>> 
>>>>  [...]
>>>> -OPTIONS_DEFINE=    DOCS
>>>> -
>>> 
>>> Commit log does not mention this change, was it intended?  If so, what
>>> was the reason behind it?
>> 
>> The line is redundant -- it's presence or absence doesn't change
>> anything.
> 
> In this case it would be nice to mention something like "remove DOCS option
> because the port no longer installs documentation" in the log.
> 
>> You know how I write commit messages and thus know I agree it
>> could have been mentioned given how short the message was (if it were 1
>> of 100 changes I wouldn't have mentioned it myself).
> 
> Yes, I know.
> 
> ./danfe
> 

Yes, you're both correct. I'm not usually a terse commit message person, and it was doubly bad given that I was doing the commit without nivit's approval. 

# Adam


--
Adam Weinberger
adamw at adamw.org
http://www.adamw.org