svn commit: r375853 - head/finance/gnucash

[Don Lewis]

On 15 Jan, Koop Mast wrote:
> 
> On 31-12-2014 8:28, Don Lewis wrote:
>> On 30 Dec, Koop Mast wrote:
>>> Author: kwm
>>> Date: Tue Dec 30 20:28:43 2014
>>> New Revision: 375853
>>> URL: https://svnweb.freebsd.org/changeset/ports/375853
>>> QAT: https://qat.redports.org/buildarchive/r375853/
>>>
>>> Log:
>>>    Fix the build on 9.x and 8.x after the update of webkit-gtk2.
>>>
>>> Modified:
>>>    head/finance/gnucash/Makefile
>>>
>>> Modified: head/finance/gnucash/Makefile
>>> ==============================================================================
>>> --- head/finance/gnucash/Makefile	Tue Dec 30 20:13:46 2014	(r375852)
>>> +++ head/finance/gnucash/Makefile	Tue Dec 30 20:28:43 2014	(r375853)
>>> @@ -96,6 +96,11 @@ GLIB_SCHEMAS+=	org.gnucash.dialogs.impor
>>>   GLIB_SCHEMAS+=	org.gnucash.dialogs.import.ofx.gschema.xml
>>>   .endif
>>>   
>>> +# because webkit-gtk2 needs it
>>> +.if ${OSVERSION} < 1000000
>>> +USES+= compiler:c++11-lib
>>> +.endif
>>> +
>> Why not just set this unconditionally.  It should be a no-op if clang is
>> the base compiler, and should do the right thing on a FreeBSD 10 machine
>> if someone has configured it to use legacy gcc as the base compiler.
> 
> Sorry for the long reply time. I wanted to make the difference between 
> that the port itself needs c++11-lib or that it was forced upon it by 
> another port.

The comment should suffice for that.  The webkit-gtk2 Makefile sets
USE=compiler:c++11-lib unconditionally.  Doing the same here would make
sure that the two ports stay in sync.