svn commit: r376996 - in head/net-mgmt: . statsite statsite/files

Alexey Dokuchaev danfe at FreeBSD.org
Wed Jan 14 05:40:37 UTC 2015


On Wed, Jan 14, 2015 at 05:25:45AM +0000, Kurt Jaeger wrote:
> New Revision: 376996
> URL: https://svnweb.freebsd.org/changeset/ports/376996
> QAT: https://qat.redports.org/buildarchive/r376996/
> 
> [...]
> +BUILD_DEPENDS=	scons:${PORTSDIR}/devel/scons

Any reason why USES=scons was not suitable here?

> +do-build:
> +	cd ${WRKSRC} && make

do-build recipe looks very bogus (and even if it's not, literal "make"
should not be used, we have ${MAKE_CMD} for that; have a look at default
do-build implementation in bpm).

> +do-install:
> +	${STRIP_CMD} ${WRKSRC}/statsite
> +	${CP} ${WRKSRC}/statsite ${STAGEDIR}/${PREFIX}/bin/

Please educate submitter that binaries are meant to be installed with
${INSTALL_PROGRAM} which does the stripping itself.

./danfe


More information about the svn-ports-all mailing list