svn commit: r395548 - head/net/pathneck

[Alexey Dokuchaev]

On Sat, Aug 29, 2015 at 11:48:57AM +0000, Babak Farrokhi wrote:
> New Revision: 395548
> URL: https://svnweb.freebsd.org/changeset/ports/395548
> 
> Log:
>   net/patchneck: Makefile cleanup
>    - Remove dead MASTER_SITES
>    - Take maintainership
>  [...]
>  
>  PLIST_FILES=	sbin/pathneck \
>  		sbin/get-choke
>  PORTDOCS=	COPYING ChangeLog README
>  MAKEFILE=	Makefile.bsd
> +USES=	tar:tgz

USES is badly indented and misplaced (MAKEFILE knob is also misplaced).
PLIST_FILES and PORTDOCS are package-related knobs, while USES are generic
so they should typically be listed first after *_DEPENDS knobs.  MAKEFILE
is build-related so usually it's also expected to be found earlier.

For a known license, you might also consider removing COPYING from PORTDOCS
and use LICENSE framework instead.

>  OPTIONS_DEFINE=	DOCS
>  
> @@ -28,6 +27,8 @@ do-install:
>  	${INSTALL_PROGRAM} ${WRKSRC}/pathneck ${STAGEDIR}${PREFIX}/sbin/pathneck
>  	${INSTALL_PROGRAM} ${WRKSRC}/get-choke \
>  		${STAGEDIR}${PREFIX}/sbin/get-choke

Since destination file name is the same as source, it can be dropped.

./danfe