svn commit: r343559 - head/net-p2p/litecoin

[David Chisnall]

On 10 Feb 2014, at 07:52, Baptiste Daroussin <bapt at FreeBSD.org> wrote:

> I do not think that requires an approval, as for FreeBSD this change is no-op,
> It is also no intrusive and just "fixes" building of that port for Dragonfly.

Relying on OPSYS and OSVERSION is pretty horrible and doesn't scale.  Already we have problems with convoluted OSVERSION expressions that are hard to understand and really mean 'fix for PR12345 has been merged to the relevant branch'.  It would be far better to centralise these into a single file for each platform, listing features / bugfixes / needed work-arounds and start removing explicit OSVERSION checks from any other Makefiles.  If supporting Dragonfly is one of our objectives, then I'd strongly encourage the people who are working on it to engage in this kind of cleanup, rather than piling more hacks into the tree.

David