svn commit: r343229 - head/graphics/libgphoto2

[John Marino]

On 2/7/2014 14:25, Martin Wilke wrote:
> 
> On Feb 7, 2014, at 9:12 PM, John Marino <freebsd.contact at marino.st> wrote:
> 
>> On 2/7/2014 14:06, Martin Wilke wrote:
>>> Author: miwi
>>> Date: Fri Feb  7 13:06:39 2014
>>> New Revision: 343229
>>> URL: http://svnweb.freebsd.org/changeset/ports/343229
>>> QAT: https://qat.redports.org/buildarchive/r343229/
>>>
>>> Log:
>>>  - Update to 2.5.3.1
>>>
>>>  PR:		185940
>>>  Submitted by:	Ports Fury
>>>
>>> Modified:
>>>  head/graphics/libgphoto2/Makefile
>>>  head/graphics/libgphoto2/distinfo
>>>
>>> Modified: head/graphics/libgphoto2/Makefile
>>> ==============================================================================
>>> --- head/graphics/libgphoto2/Makefile	Fri Feb  7 13:05:57 2014	(r343228)
>>> +++ head/graphics/libgphoto2/Makefile	Fri Feb  7 13:06:39 2014	(r343229)
>>
>>> -.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000040
>>> +.if ${OPSYS} == "FreeBSD" && ${OSVERSION} < 1000040
>>> CONFIGURE_ENV+=	LIBUSB1_CFLAGS=" " LIBUSB1_LIBS="-lusb"
>>> .endif
>>
>> Was this^^^^ some kind of style violation?
>> The pkgsrc guys get mad if quotes are used where they are not needed.
>> Why were quotes added here where clearly they are optional?
>>
> 
> my bad sorry.
> 

Okay.  I was just trying to understand if I was violating some kind of
style code, but from your response it seems that quotes aren't mandatory.

Thanks,
John