svn commit: r363361 - in head/editors/fte: . files

John Marino freebsd.contact at marino.st
Fri Aug 1 06:26:23 UTC 2014



On 8/1/2014 08:20, Alexey Dokuchaev wrote:
> On Fri, Aug 01, 2014 at 08:13:53AM +0200, John Marino wrote:
>> logic flaw: You can't just replace "/" with "-" or "_" without altering
>> "-" or "_" in the filename.
>>
>> example, given these files:
>>   ${WRKSRC}/alpha-bravo
>>   ${WRKSRC}/alpha/bravo
>>
>> if you replace "/" with "-", both have the same suggested patch name.
>> You need to alter the hyphen in alpha-bravo first.
> 
> Basically right now one patch will overwrite another conflicting one, which
> ever comes first.  I think I can add a check beforea > $${OUT} and issue an
> error and refuse to overwrite a file, or maybe just warn.  Which you prefer?
> 

Neither.  I prefer the original character escaped with itself  You may
not like this, but something like:

patch-alpha--bravo
patch-alpha-bravo

In the case of
   ${WRKSRC}/alpha_bravo
   ${WRKSRC}/alpha/bravo
using "_" as the separator, something like:

patch-alpha__bravo
patch-alpha_bravo


Thoughts?  any potential of overwritting is bad.

John


More information about the svn-ports-all mailing list