svn commit: r350792 - head/emulators/tme

[Baptiste Daroussin]

On Thu, Apr 10, 2014 at 12:16:19PM +0200, Baptiste Daroussin wrote:
> On Thu, Apr 10, 2014 at 12:11:33PM +0200, Paweł Pękala wrote:
> > Baptiste Daroussin <bapt at FreeBSD.org> wrote:
> > 
> > > On Thu, Apr 10, 2014 at 11:39:45AM +0200, Mathieu Arnold wrote:
> > > > +--On 10 avril 2014 09:11:08 +0000 Pawel Pekala <pawel at FreeBSD.org>
> > > > wrote: |   - Remove some dependencies pulled in automatically by
> > > > others
> > > > 
> > > > Ah, that feels wrong, a port should have explicit dependencies to
> > > > thing it needs to fetch/extract/build/link/run, it should not rely
> > > > on some of its dependencies bringing what it needs as sub
> > > > dependencies.
> > > > 
> > > Good catch I haven't seen that one
> > > 
> > > This is wrong because the day one of the deps stop pulling down a
> > > dependency of this port then this port will be broken
> > 
> > All removed dependencies libraries can be found in pkg -B gtk2 output,
> > which is build and run dependency (USES= gtk20) so I don't see any
> > problem here except not clear log entry.
> > 
> 
> The day gtk20 does not depends anymore on this you are doomed if those deps are
> explicitly depended on by your port
> 

With a bit more of precision: 90% of the one you removed can safely be removed
because for sure they are not directly used by tme but exposed via gtk20 in that
case it is safe to remove them. I'm not that sure about pcre or expat for example


In the end to know what should be explicitly listed the right things is on
freebsd 10 to look at the pkg info -B tme and only list the dependencies shown
here.

Why FreeBSD 10+ ? because on earlier version or freebsd ld(1) overlink. Even
there, it won't be 100% accurate because gtk pc files it known to be responsible
of a bit of overlinking and the way we use libtool in the ports tree is also
responsible of a bit of overlinking (in particular the fast that we do keep .la files)

Anyway anything not shown by pkg info -B tme on FreeBSD 10+ can safely be
removed :)

(Honnestly I think in the tme case in particular you are safe after a second review)

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140410/082253f4/attachment.sig>