svn commit: r328403 - head/Mk

[Marcus von Appen]

On, Thu Sep 26, 2013, William Grzybowski wrote:

[...]
> > +       { ${ECHO_CMD} "#mtree"; ${CAT} ${MTREE_FILE}; } | ${TAR} tf - | \
> > +               ${SED} '/^\.$$/d' > ${WRKDIR}/.localmtree
> > +       ${ECHO_CMD} "${_RELSITELIBDIR}" >> ${WRKDIR}/.localmtree
> > +       ${SED} 's|^${PREFIX}/||' ${_PYTHONPKGLIST} | ${SORT} >> ${TMPPLIST}
> > +       ${SED} -e 's|^${PREFIX}/\(.*\)/\(.*\)|\1|' ${_PYTHONPKGLIST} | \
> > +               while read line; do \
> > +                       ${GREP} -qw "^$${line}$$" ${WRKDIR}/.localmtree || { \
> > +                               [ -n "$${line}" ] && \
> > +                                       ${ECHO_CMD} "@unexec rmdir $${line} 2>/dev/null || true"; \
> > +                       }; \
> > +               done | ${SORT} | uniq | ${SORT} -r >> ${TMPPLIST}
>
> This logic iteration to find directories seems wrong.
> If I am not wrong and we have:
>
> dira/dirb/file1
> dira/dirc/file2
>
> And no files within dira/ it endes up removing dira/dirb/ and
> dira/dirc/, but not dira/.

Fixed, thanks for spotting this!

> Also, see this about enabling easy_install with AUTOPLIST and staging:
> http://people.freebsd.org/~wg/easyinstall-stage.txt

Working on it. I'm still a bit unsure about ports that do more complex
easy_install magic, so I'll try to get some of them properly tested
before committing your fix. Thanks!

Cheers
Marcus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20130927/bad18434/attachment.sig>