svn commit: r326685 - in head: devel/mercator math/wfmath

[Oliver Lehmann]

Alexey Dokuchaev <danfe at freebsd.org> wrote:

>> >2) why is it hard to create a proper patch instead;
>>
>> Why? I can't tell, I'm sorry - I just was not able to fix the clang
>> compilation problems otherwise.
>
> Again, it's hard to understand that without the documenting why USE_GCC was
> used in the first place.  Second, given the suggestion of simply removing
> misused CONFIGURE_ARGS (and provided that it does indeed solve the issue),
> I find it a bit hard to believe you could not have come up with it yourself
> Oliver. ;-)

devel/mercator got USE_GCC as otherwise it wouldn't compile with a  
gcc-compiled
math/wfmath. And math/wfmath got USE_GCC as I'm not able to fix those issues:

http://beefy1.isc.freebsd.org/bulk/head-default/2013-09-04_23h56m58s/logs/wfmath-1.0.1.log

math/wfmath has no CONFIGURE_ARGS to remove (devel/mercator has).

>> >3) is it really necessary to set USE_GCC to "yes", not "any"?
>>
>> This is what the header of bsd.gcc.mk suggests. If "any" is prefered over
>> "yes", it should be stated somewhere in the top of bsd.gcc.mk - maybe in
>> the Examples section which is where I always look first.
>
> "yes" and "any" do different things, it's not the matter of style.  "yes"
> means to use modern GCC compiler, even on systems that still use GCC as
> a system one by default (e.g. 8.x, 9.x).  "any" means that literally any
> GCC version would suffice, which means that on our stable branches, I do
> not have to install some GCC 4.6+ since I already gave GCC 4.2 in the base.

I looked the differenc between "any" and "yes"t already up after you told me
about "any" the first time by searching bsd.gcc.mk. I still think that it
would be better to have "any" also documented in bsd.gcc.mk at the top.
Maybe in the Examples section - how should anyone know about the two switches
and their meanings?

   Greetings Oliver