svn commit: r326685 - in head: devel/mercator math/wfmath

Oliver Lehmann oliver at freebsd.org
Sun Sep 8 09:53:02 UTC 2013


Alexey Dokuchaev <danfe at freebsd.org> wrote:

> This is notoriously bad commit message.  In fact, it's almost as bad as an
> empty one.

> unclear is 1) what kind of error this commit is supposed to fix;

USE_GCC was introduces because: It requires a gcc compiler to compile.
Next time I'll think more about the message to make this more clear.

> 2) why is it hard to create a proper patch instead;

Why? I can't tell, I'm sorry - I just was not able to fix the clang  
compilation
problems otherwise.

> 3) is it really necessary to set USE_GCC to "yes", not "any"?

This is what the header of bsd.gcc.mk suggests. If "any" is prefered over
"yes", it should be stated somewhere in the top of bsd.gcc.mk - maybe in
the Examples section which is where I always look first.

   Greetings, Oliver


More information about the svn-ports-all mailing list