svn commit: r332668 - in head/security: . pkesh

[Colin Percival]

On 11/05/13 23:10, Alexey Dokuchaev wrote:
> On Mon, Nov 04, 2013 at 06:05:13AM +0000, Colin Percival wrote:
>> +NO_BUILD=	YES
>> +NO_INSTALL=	YES
> 
> In ports world (in constrast with src) these are normally spelled "yes".

Yeah, I realized that a few hours later when I added the panicmail port; I
figured it wasn't worth going back to fix these in pkesh.

>> +PLIST_FILES=	bin/pkesh			\
>> +		%%PORTDOCS%%%%DOCSDIR%%/README
>> +PLIST_DIRS=	%%DOCSDIR%%
> 
> Using PORTDOCS=README would allow you to 1) get tid of eye-tearing %%'s in
> PLIST_FILES and drop PLIST_DIRS.

Huh.  I was confused by the wiki page
  https://wiki.freebsd.org/ports/StageDir
since it says "Just add the right %%PORTDOCS%% as prefix in your pkg-plist...".

>> +do-install:
>> +	${INSTALL_SCRIPT} ${WRKSRC}/pkesh.sh ${STAGEDIR}${PREFIX}/bin/pkesh
>> +
>> +post-install:
>> +	${MKDIR} ${STAGEDIR}${DOCSDIR}
>> +	${INSTALL_DATA} ${WRKSRC}/README ${STAGEDIR}${DOCSDIR}
> 
> You could've simply merged all commands in do-install target.  No need for
> two of them, really. :-)

The aforementioned wiki page says "Directory creation should remain in the
post-install: target" so that's what I did...

-- 
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid