svn commit: r319003 - head/mail/imaptools

Alexey Dokuchaev danfe at FreeBSD.org
Sat May 25 07:33:58 UTC 2013


On Sat, May 25, 2013 at 11:16:28AM +0400, Boris Samorodov wrote:
> Thanks for suggestion, I did not realise that it may be employed
> here! However after some investigation it seems it's not worth,
> since a single reinplace command should be replaced by for knobs:
> USES+SHEBANG_FILES as well as WRKSRC and NO_BUILD:

It might still be better...

> +WRKSRC=                ${WRKDIR}

Shouldn't NO_WRKSUBDIR be used instead?

> +USES=          shebangfix
> +SHEBANG_FILES= *.pl
> +NO_BUILD=      yes

Having NO_BUILD looks correct: there is, in fact, nothing gets built here.
Hence, it helps to understand port logic better, I think.

Makefile should stary mostly declarative, not imperative.  If one can get
away from manually coding some target actions, and offload the grunt work
to bpm, doesn't it make more sense to just go for it? :-)

./danfe


More information about the svn-ports-all mailing list