svn commit: r318777 - head/audio/libvorbis

Chris Rees utisoft at gmail.com
Wed May 22 20:20:30 UTC 2013


On 22 May 2013 20:26, Christian Weisgerber <naddy at mips.inka.de> wrote:
> Chris Rees:
>
>> > +OPTIONS_DEFINE=        DOCS
>>
>> Please don't do this; no-one needs an OPTIONS dialog jumping up for
>> something that should be set globally.
>>
>> You don't need DOCS, EXAMPLES, or NLS in OPTIONS_DEFINE if they're the only
>> ones used by the port.
>
> There are plenty of ports with OPTIONS_DEFINE=DOCS and no further
> options.  I changed it (against my personal preference!), because
> it looked like this was the new way.
>
> So what *is* the consensus now?
>
> Either way, the Porter's Handbook is vague.

You are quite right.

There is some discussion about whether to, or not, but the main
suggestion is that docs that require *building* would probably benefit
from this option.

I have some time set aside soon to clarify some stuff in the PH, so
I'd like to get some consensus about this.

Personally I think adding DOCS to OPTIONS_DEFINE at all under most
circumstances is a bad idea, but it appears I'm in a minority here.

Chris


More information about the svn-ports-all mailing list