svn commit: r318592 - head/benchmarks/mdtest

[Alexey Dokuchaev]

On Mon, May 20, 2013 at 10:43:12AM +0000, Boris Samorodov wrote:
> New Revision: 318592
> URL: http://svnweb.freebsd.org/changeset/ports/318592
> 
>  do-install:
> -	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin
> -	${INSTALL_MAN} ${WRKSRC}/${PORTNAME}.1 ${MANPREFIX}/man/man1
> +	(cd ${WRKSRC} && ${INSTALL_PROGRAM} ${PORTNAME} ${PREFIX}/bin)
> +	(cd ${WRKSRC} && ${INSTALL_MAN} ${PORTNAME}.1 ${MANPREFIX}/man/man1)
>  .if ${PORT_OPTIONS:MEXAMPLES}
>  	@${MKDIR} ${EXAMPLESDIR}
> -	@(cd ${WRKSRC}/scripts && ${COPYTREE_SHARE} \* ${EXAMPLESDIR})
> +	(cd ${WRKSRC}/scripts && ${INSTALL_DATA} * ${EXAMPLESDIR})

These changes are gratuitous (at least), plus I've already raised my
concerns about Kato's desire to make every INSTALL_* command needlessly
depended on current directory.  Not just it makes command line longer,
it looks worse it logs and requires reader to parse two command instead
of one.  I am also not convinced that using subshell is required.

Asterisk should have been replaced with dot as a safer alternative that
is not special shell symbol and thus does not require escaping (or worry
about it).

Given that changes are probably technically correct (Kato is usually good
on that side), I would like to reinterate that their (or whomever else)
submissions should not be committed blindly as they are.

./danfe