svn commit: r318576 - head/mail/sendmail-sasl

[Baptiste Daroussin]

On Mon, May 20, 2013 at 12:25:49AM -0700, Jason Helfman wrote:
> On Mon, May 20, 2013 at 12:15 AM, Dirk Meyer <dinoex at freebsd.org> wrote:
> 
> > Author: dinoex
> > Date: Mon May 20 07:15:33 2013
> > New Revision: 318576
> > URL: http://svnweb.freebsd.org/changeset/ports/318576
> >
> > Log:
> >   - fix option name
> >   PR:           178776  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=178776
> >   Submitted by: Lawrence Chen
> >
> >   - fix option SASLAUTHD
> >
> > Modified:
> >   head/mail/sendmail-sasl/Makefile
> >
> > Modified: head/mail/sendmail-sasl/Makefile
> >
> > ==============================================================================
> > --- head/mail/sendmail-sasl/Makefile    Mon May 20 06:20:28 2013
> >  (r318575)
> > +++ head/mail/sendmail-sasl/Makefile    Mon May 20 07:15:33 2013
> >  (r318576)
> > @@ -5,7 +5,8 @@ CATEGORIES=     mail ipv6
> >  MAINTAINER=    dinoex at FreeBSD.org
> >
> >  WITH_TLS=      yes
> > -WITH_SASL2=    yes
> > +WITH_SASL=     yes
> > +WITH_SASLAUTHD=        yes
> >  SENDMAIL_PORT?=                sendmail
> >  MASTERDIR?=    ${.CURDIR}/../${SENDMAIL_PORT}
> >
> >
> >
> Since mail/sendmail was converted to optionsNG, shouldn't these options be
> defined similarly with the new framework?

Yes it should
> 
> OPTIONS_SET= TLS SASL2 SASL SASLAUTHD

No not that way OPTIONS_SET and OPTIONS_UNSET should never ever be used in a
ports Makefile

OPTIONS_SLAVE has been written for that
It does 2 things: 
1- it makes sure the options are activated in the slave
2- it removes the specified options for the options the user can select.

> 
> -jgh
> 
> --
> Jason Helfman          | FreeBSD Committer
> jgh at FreeBSD.org     | http://people.freebsd.org/~jgh  | The Power to Serve
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20130520/234781c0/attachment.sig>