svn commit: r318379 - in head/comms: . gr-osmosdr gr-osmosdr/files

[Alexey Dokuchaev]

On Fri, May 17, 2013 at 01:10:11PM +0000, Ganael LAPLANCHE wrote:
> New Revision: 318379
> URL: http://svnweb.freebsd.org/changeset/ports/318379
> 
> +BUILD_DEPENDS=	swig:${PORTSDIR}/devel/swig13 \
> +		doxygen:${PORTSDIR}/devel/doxygen \

Oh, is doxygen being used for documentation, or this port actually really
needs it for something functional?  If it's only for docs, can it be made
OPTIONal?

> +		cheetah:${PORTSDIR}/devel/py-cheetah
> +LIB_DEPENDS=	gnuradio-core:${PORTSDIR}/comms/gnuradio \
> +		gnuradio-fcd:${PORTSDIR}/comms/gnuradio \
> +		gruel:${PORTSDIR}/comms/gnuradio \
> +		boost_system:${PORTSDIR}/devel/boost-libs \
> +		boost_thread:${PORTSDIR}/devel/boost-libs

Doubling dependencies of comms/gnuradio and boost-libs looks a bit silly;
just picking one library per port would be sufficient.

> +OPTIONS_DEFINE=	RTLSDR
> +RTLSDR_DESC=	Enable rtl-sdr (RTL2832) support

We've been discouraging starting support-type descriptions with 'Enable'
word, but in this case it also helps to avoid starting description with
lower-case letter (presuming that "rtl-sdr" spelled correctly), so maybe
it's OK.

./danfe