svn commit: r318182 - in head/ports-mgmt: kports kports-qt4

Raphael Kubo da Costa rakuco at FreeBSD.org
Wed May 15 22:27:18 UTC 2013


Alexey Dokuchaev <danfe at FreeBSD.org> writes:

> On Wed, May 15, 2013 at 09:32:33AM +0800, Martin Wilke wrote:
>> On May 15, 2013, at 9:20 AM, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
>> > On Tue, May 14, 2013 at 06:09:22PM +0000, Raphael Kubo da Costa wrote:
>> >> New Revision: 318182
>> >> URL: http://svnweb.freebsd.org/changeset/ports/318182
>> >> 
>> >> COMMENT=	Qt4-Version of your favorite frontend to the Ports
>> >> [...]
>> >> COMMENT=	KDE3-Version of your favorite frontend to the Ports
>> > 
>> > Hm,
>> > 
>> > 1) Why "version" is capitalized and prepended with hyphen?
>> > 2) COMMENT should not talk to a user (no "your" part) and assume its
>> >   preferences and likes ("favorite" part)
>> > 3) "Ports" can probably be expanded to "Ports Collection" or something
>> 
>> Another style discussion?
>
> I would not say so.  Correct use of language != style.

In any case, not only were these lines not changed by this patch but the
actual port maintainer is probably not even reading the discussion :-)

Adding him to the CC list.


More information about the svn-ports-all mailing list