svn commit: r317243 - head/deskutils/menumaker

[Chris Rees]

On 4 May 2013 06:06, "Alexey Dokuchaev" <danfe at freebsd.org> wrote:
>
> On Fri, May 03, 2013 at 08:40:23PM +0000, Baptiste Daroussin wrote:
> > New Revision: 317243
> > URL: http://svnweb.freebsd.org/changeset/ports/317243
> >
> > Log:
> >   Fix build with bmake
> >
> > @@ -14,6 +10,7 @@ MAINTAINER= ports at FreeBSD.org
> >  COMMENT=     Menu generator for X Window Managers and desktop
environments
> >
> >  USE_PYTHON=  yes
> > +USE_GMAKE=   yes
>
> Since you decided not to surround it with bmake-specific conditional this
> time, I think it would be nice to add a comment instead, e.g.:
>
>     USE_GMAKE=yes                       # fails with bmake(1)
>
> I usually try to check periodically why some ports need gmake(1); it would
> make it easier for me with such comments, thanks!

I prefer the PARSEDIR solution, but however you do it, please be
consistent; I want to work on fixing these upstream and need something to
grep for!

Chris