svn commit: r315412 - head/security/vuxml

[Eygene Ryabinkin]

Thu, Mar 28, 2013 at 02:41:14AM +0000, Alexey Dokuchaev wrote:
> On Wed, Mar 27, 2013 at 08:44:51PM +0000, Xin LI wrote:
> > New Revision: 315412
> > URL: http://svnweb.freebsd.org/changeset/ports/315412
> > 
> > Log:
> >   Explicitly use -E for sed(1).
> >   
> >   Submitted by:	des
> >   Reviewed by:	eadler
> > 
> > -	@unexpand "${VUXML_FILE}" | ${SED} 's,[[:space:]]*$$,,g' > "${VUXML_FILE}.unexpanded"
> > +	@unexpand "${VUXML_FILE}" | ${SED} -E 's,[[:space:]]*$$,,g' > "${VUXML_FILE}.unexpanded"
> 
> Why -e is insufficient here?

Well, slightly better question is 'why had you added -E that enabled
modern re processing', because the change from '${SED} <pattern>' to
'${SED} -e <pattern>' is a no-op.  And the right answer is "That was
a redundant change":
{{{
$ echo SSBoYXZlIHRyYWlsaW5nIHNwYWNlLCBjbGVhbiBtZSEJCSAK | openssl base64 -d | sed 's/[[:space:]]*$/<fixed>/g'
I have trailing space, clean me!<fixed>

$ echo SSBoYXZlIHRyYWlsaW5nIHNwYWNlLCBjbGVhbiBtZSEJCSAK | openssl base64 -d | sed -E 's/[[:space:]]*$/<fixed>/g'
I have trailing space, clean me!<fixed>
}}}

We will try to fix that or to understand why des@ suggested it,
thanks for spotting!
-- 
Eygene Ryabinkin                                        ,,,^..^,,,
[ Life's unfair - but root password helps!           | codelabs.ru ]
[ 82FE 06BC D497 C0DE 49EC  4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20130328/6365d35d/attachment.sig>