svn commit: r321677 - in head/security/duo: . files

Alexey Dokuchaev danfe at FreeBSD.org
Mon Jun 24 12:03:16 UTC 2013


On Mon, Jun 24, 2013 at 11:55:42AM +0000, Ryan Steinmetz wrote:
> New Revision: 321677
> URL: http://svnweb.freebsd.org/changeset/ports/321677
> 
> +.if ${OSVERSION} >= 1000000
> +USE_GCC=	yes
> +.endif

Presuming it's due to Clang...

Two quick questions: 1) why not just say USE_GCC=any; and 2) how hard would
it be to fix Clang fallouts, and remove any explicit compiler requirement?

Note that =yes implies GCC 4.6+ or something, yet on OSVERSION < 1000000
apparently our default system 4.2 is enough.

>  	@${CAT} ${PKGMESSAGE}

It would be nice if cat(1) had been surrounded with ${ECHO_MSG}'s to ensure
consistent padding when installing from package vs. ports.  If any padding
is present in the pkg-message file itself, it should be removed.

./danfe


More information about the svn-ports-all mailing list