svn commit: r321372 - in head/sysutils/zxfer: . files

[Steve Wills]

On 06/20/13 12:11, Boris Samorodov wrote:
> 20.06.2013 15:46, Steve Wills пишет:
>> Author: swills
>> Date: Thu Jun 20 11:46:31 2013
>> New Revision: 321372
>> URL: http://svnweb.freebsd.org/changeset/ports/321372
>>
>> Log:
>>   - Add ro properties for FreeBSD 9.1
>>   
>>   PR:		ports/178567
>>   Submitted by:	Mark Felder <feld at feld.me>
>>   Approved by:	maintainer timeout (ivannashdreckman at fastmail.fm, >4 weeks)
> [...]
>> + # Properties not supported on FreeBSD 8.2
>> +-fbsd_readonly_properties="aclmode,aclinherit,devices,nbmand,shareiscsi,vscan,xattr"
>> ++fbsd_readonly_properties="aclmode,aclinherit,devices,nbmand,shareiscsi,vscan,xattr,refcompressratio,written"
> -----
> 
> Something is not consistent here (9.1 vs 8.2).
> 

Yes, I think the comment is wrong, but the code is right. As Mark said
in another mail:

> zxfer hasn't been updated since 8.x days. Those are all known ro
attributes for 8.2. Adding *more* ro attributes won't hurt if you're
running on 8.x. However, not having all possible FreeBSD ro attributes
means that port is "broken" on >8.2 as it would not run on 8.4 now with
newer zfs code.

Steve