svn commit: r320546 - in head/devel: . tradcpp tradcpp/files

[Baptiste Daroussin]

On Tue, Jun 11, 2013 at 06:48:34PM +0200, Eitan Adler wrote:
> On Tue, Jun 11, 2013 at 6:40 PM, Baptiste Daroussin <bapt at freebsd.org> wrote:
> > No patching is better, has I'm heavily working with upstream on this port.
> >
> > In general disable warning is something I don't like, I prefer to fix them, and
> > I don't find that complexify the port at all.
> 
> I've found patching software often leads to introducing subtle bugs:
> its incredibly annoying trying to track down a bug only to determine
> that is is a distro patch.  Also, it makes it more difficult for the
> reader of the patch to figure out why the patch is there:
> it increases the mental effort before "oh, maintainer is just working
> around compiler warnings"
> 
> That said, this isn't a strong feeling.

I know exactly what I'm doing and why, I know why I do patch, and I'm working as
said in the previous mail directly with upstream (those patches are now
integrated in better vesions).

I think I have enough experience in the ports tree to decide if I should patch
or not my own ports.

bapt,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20130611/6454f7e9/attachment.sig>