svn commit: r320546 - in head/devel: . tradcpp tradcpp/files

[Baptiste Daroussin]

On Tue, Jun 11, 2013 at 06:33:37PM +0200, Eitan Adler wrote:
> On Tue, Jun 11, 2013 at 12:55 PM, Baptiste Daroussin <bapt at freebsd.org> wrote:
> > --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> > +++ head/devel/tradcpp/files/patch-directive.c  Tue Jun 11 10:55:16 2013        (r320546)
> > + static
> > + void
> > +-d_line(struct place *p, struct place *p2, char *line)
> > ++d_line(struct place *p, struct place *p2 __unused, char *line __unused)
> ...
> > +-d_pragma(struct place *p, struct place *p2, char *line)
> > ++d_pragma(struct place *p, struct place *p2 __unused, char *line)
> ...
> > +-filter_output(const struct place *p, const char *buf, size_t len)
> > ++filter_output(const struct place *p __unused, const char *buf, size_t len)
> 
> 
> Perhaps we could build without warnings instead of patching the
> source? this would simplify the port and make it more obvious what is
> being solved.
> 
> 
> -- 
> Eitan Adler
> Source, Ports, Doc committer
> Bugmeister, Ports Security teams

No patching is better, has I'm heavily working with upstream on this port.

In general disable warning is something I don't like, I prefer to fix them, and
I don't find that complexify the port at all.

Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20130611/38251537/attachment.sig>