svn commit: r319792 - head/sysutils/fsc

[Baptiste Daroussin]

On Mon, Jun 03, 2013 at 03:51:06PM -0400, Tom Rhodes wrote:
> On Mon, 03 Jun 2013 13:12:37 -0500
> Bryan Drewery <bdrewery at FreeBSD.org> wrote:
> 
> > On 6/3/2013 12:30 PM, Tom Rhodes wrote:
> > > On Mon, 03 Jun 2013 11:51:32 -0500
> > > Bryan Drewery <bdrewery at FreeBSD.org> wrote:
> > > 
> > >> This is bad form. If you are changing upstream code it should be a new
> > >> release version, not a reroll. We frequently have problems with other
> > >> upstreams doing this and should follow our own guidelines.
> > > 
> > > I'm not bumping the version used for a simple gcc->clang warning
> > > fix.  That's why I just bumped PORTVERSION.  If we want to do a
> > > new version, I'll get ahold of the NetBSD people, who also work
> > > with keeping a port, and discuss doing that.  In this case, it
> > > was a simple fix rather than adding a 2 line patch to a files/
> > > directory.
> > > 
> > 
> > The proper way to do is this a new release, or a patch in files with a
> > PORTREVISION, or a sed in post-patch. This is the convention. Rerolling
> > upstream is a big no no. Rerolling is obscure and very frowned upon.
> > This also impacts NetBSD if they are tracking checksums, and any other
> > projects depending on the checksum of the upstream tarball.
> 
> I'll look at bumping the release version - there are some other
> changes that need made anyway, I just wanted to fix the build so
> users could build it again.

In that case a patch in files/ is the way to go.
> 
> > 
> > If you had a ports committer approve/review this change, which you
> > should have and should do in the future, this would have been avoided.
> 
> I am a ports committer, sorry I forgot about this - considering I
> commit to this area rarely.  So you can remind me about the rule,
> link to relevant documention, and I will remember for the future
> or "fix" the issue.  No attitude needed.

According the following:
http://svnweb.freebsd.org/ports?view=revision&revision=182927

You removed yourself your commit bit 6 years ago.

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20130603/db055cba/attachment.sig>