svn commit: r323836 - in head/devel: . arm-eabi-binutils arm-eabi-binutils/files

[Jason Helfman]

On Sun, Jul 28, 2013 at 9:45 AM, Tim Kientzle <kientzle at freebsd.org> wrote:

> Author: kientzle (src committer)
> Date: Sun Jul 28 16:45:22 2013
> New Revision: 323836
> URL: http://svnweb.freebsd.org/changeset/ports/323836
>
> Log:
>   Add arm-eabi-binutils cross-tools.
>
>   Approved by:  db
>
> Added: head/devel/arm-eabi-binutils/Makefile
>
> ==============================================================================
> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> +++ head/devel/arm-eabi-binutils/Makefile       Sun Jul 28 16:45:22 2013
>      (r323836)
> @@ -0,0 +1,47 @@
> +# $FreeBSD$
> +
> +PORTNAME=      binutils
> +PORTVERSION=   2.23.2
> +CATEGORIES=    devel
> +MASTER_SITES=  ${MASTER_SITE_SOURCEWARE}
> +MASTER_SITE_SUBDIR=    binutils/releases
> +PKGNAMEPREFIX= arm-eabi-
> +
> +MAINTAINER=    kientzle at gmail.com
> +COMMENT=       GNU binutils for vanilla ARM cross-development
> +
> +.if !defined(WITHOUT_NLS)
> +USE_GETTEXT=   yes
> +PLIST_SUB+=    NLS=""
> +.else
> +CONFIGURE_ARGS+=       --disable-nls
> +PLIST_SUB+=    NLS="@comment "
> +.endif
> +USE_BZIP2=     yes
> +USE_GMAKE=     yes
> +USES=          gettext
> +GNU_CONFIGURE= yes
>
>
Is there any particular reason that bsd.port.options.mk wasn't included
here?

USE_GETTEXT is deprecated, and should be using the USES framework to bring
in the dependency. The only reason this dependency is working is that it is
unconditionally brought in with the USES framework later in the Makefile.

To this affect, if NLS is disabled, it brings in gettext dependency. Can it
be disabled?

USE_GMAKE can be converted, as well, to the USES framework. (USES= gmake)

.include <bsd.port.options.mk>

.if ${PORT_OPTIONS:MNLS}
USES+= gettext
...
.endif

Regardless, as always, thank you so much for your time and effort to work
and get this inclusion into the tree, as I am sure many will benefit from
it.

-jgh

-- 
Jason Helfman          | FreeBSD Committer
jgh at FreeBSD.org     | http://people.freebsd.org/~jgh  | The Power to Serv