svn commit: r323495 - head/games/f1lt

Alexey Dokuchaev danfe at FreeBSD.org
Wed Jul 24 16:30:42 UTC 2013


On Tue, Jul 23, 2013 at 06:31:51PM +0200, Baptiste Daroussin wrote:
> On Tue, Jul 23, 2013 at 06:21:00PM +0200, John Marino wrote:
> > On 7/23/2013 18:15, Bryan Drewery wrote:
> > > Quite the contrary. If a change is needed it should be done now, not in
> > > 2 months or years when it is convenient. Smaller logical commits are
> > > much simpler to review and bisect than large commits. We should group
> > > PORTVERSION/PORTREVISION changes together to prevent *rebuild churn*.
> > 
> > "If a change is needed" [...]
> 
> That said, I do prefer a couple of sweep commits let's say remove all
> MAKE_JOBS_SAFE from the ports I do maintain in a single commit than doing
> it 1 by 1.

Exactly my point.  MAKE_JOBS_SAFE is simply on-op now.  Surely it's better
to clean 'em up, but not on per-port basis (unless accompanied with other
changes).

./danfe


More information about the svn-ports-all mailing list