svn commit: r323495 - head/games/f1lt

[Bryan Drewery]

On 7/23/2013 2:08 AM, Alexey Dokuchaev wrote:
> On Mon, Jul 22, 2013 at 07:16:07PM +0000, Jason Helfman wrote:
>> New Revision: 323495
>> URL: http://svnweb.freebsd.org/changeset/ports/323495
>>
>> Log:
>>   - drop default MAKE_JOBS_SAFE
> 
> Folks (not just Jason),
> 
> I think making such commits which touch one file and essentially do not do
> anything other than causing extra repo churn and noise (+ few thousands
> commit messages people will find in their mailboxes) is something we should
> rather avoid.  Removing MAKE_JOBS_SAFE while doing something else on the
> port is fine.  Removing MAKE_JOBS_SAFE in all ports you maintain, or all
> ports in a category is also fine.  Removing MAKE_JOBS_SAFE and nothing else
> from one Makefile per commit -- perhaps not that fine.
> 
> ./danfe
> 

Quite the contrary. If a change is needed it should be done now, not in
2 months or years when it is convenient. Smaller logical commits are
much simpler to review and bisect than large commits. We should group
PORTVERSION/PORTREVISION changes together to prevent *rebuild churn*.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20130723/aee2f209/attachment.sig>