svn commit: r322724 - head/net-p2p/qbittorrent

[Alexey Dokuchaev]

On Thu, Jul 11, 2013 at 10:03:05AM -0300, William Grzybowski wrote:
> On Thu, Jul 11, 2013 at 9:55 AM, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> > On Thu, Jul 11, 2013 at 08:42:23AM -0300, William Grzybowski wrote:
> >> On Thu, Jul 11, 2013 at 2:45 AM, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> >> > On Wed, Jul 10, 2013 at 05:54:43PM +0000, William Grzybowski wrote:
> >> >> New Revision: 322724
> >> >> URL: http://svnweb.freebsd.org/changeset/ports/322724
> >> >>
> >> >> @@ -43,7 +46,7 @@ CONFIGURE_ARGS+=    --disable-qt-dbus
> >> >>  .endif
> >> >>
> >> >>  post-patch:
> >> >> -     @${REINPLACE_CMD} -e 's,qputenv,!&,' ${WRKSRC}/src/main.cpp
> >> >> +     @${REINPLACE_CMD} -e 's|qputenv|!&|' ${WRKSRC}/src/main.cpp
> >> >
> >> > There are two problems with this part:
> >> > [...]
> >>
> >> It would make everyones life easier if you had put a comment in the
> >> post-patch line about that fact.
> >
> > True; usually I document any REINPLACE_CMD which might be confusing to
> > others, in this case I thought it's kinda self-explanatory.  The point
> > is that 1) many porters/comitters do not document these things, and it
> > might happen to anyone else; 2) regardless of the presence of comment,
> > or lack thereof, anyone who is updating the port should recheck if any
> > previous patch(es) are still valid.  This was obviously not done here.
> 
> Point taken, twice, and I appreciate your comments, I screwed up.
> How long should I knee in grains of corn? ;)

William, :)

Man, sorry if I didn't make it clear; I was mainly not targeting you,
but new maintainer (the last paragraph of my first mail suggests it).

./danfe