svn commit: r322724 - head/net-p2p/qbittorrent

Alexey Dokuchaev danfe at FreeBSD.org
Thu Jul 11 13:06:06 UTC 2013


On Thu, Jul 11, 2013 at 07:50:00AM -0500, Mark Linimon wrote:
> On Thu, Jul 11, 2013 at 05:45:33AM +0000, Alexey Dokuchaev wrote:
> > 1) It gratuitously changes perfectly fine commas to (also perfectly fine
> > as it might seem) bars.  Gratuitous commits should generally be avoided,
> > as they decrease STN ratio, and most importantly, they break 'svn blame';
> 
> This is exactly how I feel about non-code changes (e.g. whitespace,
> headers, formatting), and why I am in general against sweeps to implement
> such changes.

I know Mark, and I also know and remember that I myself was accused by these
reasons when cleaning up UPDATING notes.  There is a difference, however:
I usually touch (touched, haven't done that for a while) UPDATING after some
time had passed, so highly volatile, recent notes are retained in their form
for everyone's benefit; I usually group cleanup commits together in one bulk
to minimize the damage.  Not to mention that UPDATING information is a lot
more relaxed in their importance compared to regular port updates.

There should be a balance between the two.  Crap (even whitespace-natured),
should be removed, but at the right time, and without interfering with any
functional changes.

./danfe


More information about the svn-ports-all mailing list