svn commit: r321982 - in head/net: . hanstunnel hanstunnel/files

[Adam Weinberger]

On 2013-07-01, at 13:30, Felippe de Meirelles Motta <lippe at FreeBSD.org> wrote:

> danfe@, bsam@ and others thanks for the points mentioned, some I had noticed, others I had really missed, but I just could not manipulate the outcome of the patches without proper approval of the maintainer, because this is your role.

Sorry but I totally disagree. As committers, we (supposedly) know what is best, and the right way to do things. External maintainers are submitters; they can make mistakes and you can catch and fix them, within reason. On the whole, people are quite appreciative when you commit their patch quickly with small modifications, rather than dragging the PR for weeks while you wait for a spelling fix.

I mean, don't go changing the logic or anything, but all the time I close PR's with "Committed, but I fixed MASTER_SITE to use the source forge macro" or whatever. Never once have I heard anything except "Thank you," and best of all, next time they submit a PR they get it right.

I really don't understand why you'd rather commit something you know to be wrong. DTRT and don't be a pedant.

# Adam
 

--
Adam Weinberger
adamw at adamw.org
http://www.adamw.org