svn commit: r303626 - head/www/xpi-firebug

[Chris Rees]

Hi Shaun,

I've pinged a few times since you rejected my patch, and I'll paste
below my email from 16/Jan that shows how patches aren't affected by
an extra newline (neither are shars).

I'll give you a few days to consider a response, but I have had others
ask me if this is fixed yet, so it needs fixing.

Chris



Hi Shaun,

Have you considered my response?  I've just been bitten by this again...

As an exercise, have a look at the response here:

[crees at pegasus]~/public_html/scratch/patch-games% <patch2.txt patch
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- fileone 2013-01-16 19:22:37.442048087 +0000
|+++ filetwo 2013-01-16 19:22:47.731048632 +0000
--------------------------
Patching file fileone using Plan A...
Hunk #1 succeeded at 1.
Hmm...  Ignoring the trailing garbage.
done

I'd like to highlight the "Ignoring the trailing garbage" above,
referring to the extra newline in patch2.txt.  It doesn't break
anything!

The files I used are available at [1], I hope I haven't made it too confusing.

Chris

[1] http://www.bayofrum.net/~crees/scratch/patch-games/

On 4 September 2012 17:52, Chris Rees <utisoft at gmail.com> wrote:
> On 4 September 2012 17:49, Shaun Amott <shaun at freebsd.org> wrote:
>> On Tue, Sep 04, 2012 at 05:41:17PM +0100, Chris Rees wrote:
>>> The bug is with query-pr.cgi it appears....  We'll never get that
>>> fixed, given that gnats3 has been removed from the ports tree.  I'll
>>> put a patch together if clusteradm/bugmeisters were prepared to have a
>>> go-- I could revive the old port skel for it.
>>>
>>> Any takers?  Or shall this just remain unfixed?
>>
>> The various web scripts are not part of the GNATS distribution. Any bugs
>> in query-pr.cgi are down to me. :-)
>
> Sorry, Florian has just pointed that out to me.
>
> I thought it may have been a rogue chomp; somewhere, but apparently not.
>
> In the meantime this will work perfectly.
>
> http://www.bayofrum.net/~crees/patches/query-pr-getpr.diff
>
> Thoughts?
>
> Chris