svn commit: r332017 - head/devel/subversion17

[Tijl Coosemans]

On Sun, 08 Dec 2013 23:26:27 +0100 olli hauer wrote:
> On 2013-12-08 16:09, Matthias Andree wrote:
>> Am 07.12.2013 15:07, schrieb Tijl Coosemans:
>>> On Mon, 02 Dec 2013 18:03:16 +0100 Mathieu Arnold wrote:
>>>> +--On 29 octobre 2013 22:01:05 +0000 Olli Hauer <ohauer at FreeBSD.org> wrote:
>>>> | -PKGNAMESUFFIX=	17
>>>> | +#7setting7PKGSUFFIX7not7possible7wo.7having7a7Mk/Uses7file7and7fixing7a7
>>>> | bunch7of7ports
>>>> | +#PKGNAMESUFFIX=	17
>>>>
>>>> I've grepped through the whole ports tree, and I couldn't find any port
>>>> that depends on subversion1[67] using their package name, as in
>>>> subversion<1.8:{$PORTS}..., they only depends on the svn binary being
>>>> there, so adding PKGNAMESUFFIX will not hurt any bit.
>>>>
>>>> If I'm wrong, please show me which ports have their dependencies that needs
>>>> fixing.
>>>
>>> The subversion-java slave port sets PKGNAMESUFFIX=-java, so setting
>>> PKGNAMESUFFIX=17 in the master makefile would override that.
>>>
>>> The other slave ports (perl,ruby,python) set PKGNAMEPREFIX so maybe
>>> the java port should do that too.
>> 
>> Is there any purpose in keeping old garbage around?
>> Such as new client not working with old server?
>> If not, let's just axe the older versions rather than fix package name
>> conflicts.
> 
> The subversion java port is fixed, I'm more concerned with ports using
> 
> - ..._DEPENDS= subversion>=$version
> - ..._DEPENDS= p5-subversion>=$version
> - ..._DEPENDS= ${PYTHON_PKGNAMEPREFIX}subversion>=0:
> 
> Having PKGNAMEPREFIX will prevent building this ports in case default
> subversion != devel/subversion even they work fine with subversion 1.6.
> 
> I'm going now over all ports depending on 'devel/subversion*' to check for
> false declaration e.g using 'subversion>=1.7.0:' where 1.6 is sufficient.
> 
> Long time ago I've written a SVN framework, but got no or negative feedback
> so I stopped the work. Hopefully I can find a bunch of time to start working
> again on it.
> 
> http://lists.freebsd.org/pipermail/freebsd-ports/2011-July/068561.html

You can set PKGNAMESUFFIX only on the master subversion ports.  For the
bindings there's only one package so there's no package name conflict.
This way *_DEPENDS=p5-subversion>=$version would continue to work.

For ports that depend on subversion itself maybe we can create USES=svn.
The attached patch is a first attempt at that.  It allows ports to
depend on subversion (build,run,build+run,fetch).  It also supports
DEFAULT_VERSIONS, so users can set "DEFAULT_VERSIONS= subversion=1.7"
in make.conf and then USES=svn will depend on devel/subversion17.

Ports that don't work with particular versions of subversion could use
something like:

.if ${SUBVERSION_DEFAULT} == 1.6
IGNORE=	Port requires subversion 1.7 or higher
.endif
-------------- next part --------------
A non-text attachment was scrubbed...
Name: svn.mk.patch
Type: text/x-patch
Size: 5356 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20131209/31e54a78/attachment.bin>