svn commit: r301362 - in head: archivers/libcomprex audio/libmtp audio/libsidplay2 cad/adms databases/dbh10 databases/mysqlcppapi devel/bufferpool devel/clanlib devel/compiz-bcop devel/dotconf deve...

[Jeremy Messenger]

On Sun, Jul 22, 2012 at 9:03 PM, Doug Barton <dougb at freebsd.org> wrote:
> On 07/22/2012 18:47, Jeremy Messenger wrote:
>> On Sun, Jul 22, 2012 at 8:33 PM, Doug Barton <dougb at freebsd.org> wrote:
>>> Author: dougb
>>> Date: Mon Jul 23 01:33:55 2012
>>> New Revision: 301362
>>> URL: http://svn.freebsd.org/changeset/ports/301362
>>>
>>> Log:
>>>   For ports maintained by ports@ where pkgconfig is one of the USE_GNOME deps
>>>   convert it to BUILD_DEPENDS. This avoids the problem of the bogus run dep
>>>   added by bsd.gnome.mk.
>> <snip>
>>
>> You should wait for bapt@ on this one. He is going to work on USE_PKGCONFIG.
>
> If bapt's solution materializes, and if it's appropriate for these
> particular ports, then it can still be utilized. The only thing that is
> different now is that these ports match a different grep pattern, one
> that will have to be searched for anyway.
>
> IOW, this change doesn't hurt anything long term, and it does solve the
> bogus run-dep problem now.

It doesn't hurt, but you are making more work for bapt by chase all of
your change. bapt wants to add WANT_PKGCONFIG to allow us to choice
either pkg-config or pkgconf, so that line will be changed either.

> Oh, and for this set of ports removing USE_GNOME is a double feature,
> since it didn't need to be included there in the first place.
>
> Doug
>
> --
>
>     Change is hard.


-- 
mezz.freebsd at gmail.com - mezz at FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/ - gnome at FreeBSD.org