svn commit: r301039 - head/archivers/zlib

Ruslan Mahmatkhanov cvs-src at yandex.ru
Thu Jul 19 06:22:28 UTC 2012


Doug Barton wrote on 18.07.2012 04:05:
> On 07/17/2012 04:44 PM, Alex Kozlov wrote:

>> It works because sh assume EOF == EOL, it's would fall in more strict parser.
>
> My first question to zi was, "Are you seeing any specific problems
> caused by this?" If you can answer that question with real, specific
> information then we can talk about that. If your concern is that it
> *might* cause unknown problems with some unknown thing at some unknown
> time in the future then I restate my original thesis: We have bigger
> things to worry about, and this change isn't worth the repo churn.
>
> Doug

The most obvious "problem" is that it triggers portlint warning and 
portlint instructs committers to fix that. Period.

I agree that this is rather rare, and I only got such distinfo's when 
editing them manually (when I didn't know about `make makesum'). If 
there is consensus that this problem is not a problem at all, portlint 
should be changed and all  will be happy.

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.




More information about the svn-ports-all mailing list