svn commit: r309705 - in head/irc: . dxirc

[Baptiste Daroussin]

On Mon, Dec 31, 2012 at 09:06:26AM -0500, Jason E. Hale wrote:
> On Monday, December 31, 2012 03:46:27 Jason Helfman wrote:
> > Added: head/irc/dxirc/Makefile
> > ============================================================================
> > --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> > +++ head/irc/dxirc/Makefile     Mon Dec 31 03:46:26 2012        (r309705)
> > @@ -0,0 +1,80 @@
> >
> > +LICENSE=	GPLv3
> > +LICENSE_FILE=	${WRKSRC}/COPYING
> 
> LICENSE_FILE should be dropped for standard license
> 
> > +LIB_DEPENDS=	FOX-1:${PORTSDIR}/x11-toolkits/fox16
> 
> The library name is FOX-1.6 despite portlint warnings ".6" is not an ABI 
> version number.

and even if it was in that case it shouldn't be removed because in here we only
want fox16 and not fox17 for example.
> 
> > +OPTIONS_DEFINE=	NLS TRAY IPV6 SSL LUA ENCHANT NOTIFY
> > +OPTIONS_DEFAULT=	NLS TRAY IPV6 SSL LUA
> 
> NLS doesn't need to be in OPTIONS_DEFAULT...it is already default.  Might as 
> well add DOCS to OPTIONS_DEFINE too.

IPV6 and NLS does not need the framework does it by default
> 
> > Added: head/irc/dxirc/pkg-plist
> > ============================================================================
> > == --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ head/irc/dxirc/pkg-plist	Mon Dec 31 03:46:26 2012	(r309705)
> > @@ -0,0 +1,297 @@
> > +%%DATADIR%%/COPYING
> 
> Since LICENSE is already defined, the installation of an additional license 
> file should be squashed.
> 
> > + at dirrm share/applications
> 
> This should be a @dirrmtry since it is a shared directory.
> 
> -- 
> Jason E. Hale - jhale@
> FreeBSD Ports Committer
> KDE/FreeBSD Team
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20121231/f6315ea1/attachment-0001.sig>