svn commit: r309264 - head/security/oidentd

[Gerald Pfeifer]

On Wed, 19 Dec 2012, Eitan Adler wrote:
> On 19 December 2012 15:25, Oliver Lehmann <oliver at freebsd.org> wrote:
>> +CONFIGURE_ENV+=        CFLAGS="${CFLAGS} -std=gnu89"
> 
> Why not
> 
> USE_CSTD=gnu89 ?

First and foremost: why add CFLAGS="${CFLAGS}" to CONFIGURE_ENV?

Mk/bsd.port.mk already has the following:

   if ! ${SETENV} CC="${CC}" CPP="${CPP}" CXX="${CXX}" \
   CFLAGS="${CFLAGS}" CPPFLAGS="${CPPFLAGS}" CXXFLAGS="${CXXFLAGS}" \
   :
   ${CONFIGURE_ENV} ./${CONFIGURE_SCRIPT} ${CONFIGURE_ARGS}; then \
        ${ECHO_MSG} "===>  Script \"${CONFIGURE_SCRIPT}\" failed unexpectedly."; \

And portlint warns about it as well:

   WARN: Makefile: [34]: use a tab (not space) after a variable name
   WARN: Makefile: CFLAGS/CXXFLAGS are not needed in CONFIGURE_ENV as they are already added there in bsd.port.mk.

Can you please fix those two?

Gerald