svn commit: r308924 - head/print/qpdfview

[Jason Helfman]

On Fri, Dec 14, 2012 at 11:57 PM, Max Brazhnikov <makc at freebsd.org> wrote:

> Hi Jason,
>
> On Fri, 14 Dec 2012 19:43:35 +0000 (UTC)Fri Dec 14 19:43:35 2012, Jason
> Helfman wrote:
> > -PORTVERSION=   0.3.1
> > +PORTVERSION=   0.3.7
> >  CATEGORIES=    print
> > -MASTER_SITES=  https://launchpadlibrarian.net/109087731/
> > +MASTER_SITES=  https://launchpadlibrarian.net/125207295/
> > +DISTNAME=      ${PORTNAME}-${PORTVERSION}beta1
>
> You should have used DISTVERSION= 0.3.7beta1 here, you wouldn't need to
> specify DISTNAME and would get correct 0.3.7.b1 for PORTVERSION
> automatically.
> Unfortunately it can't be fixed now without bumping PORTEPOCH and perhaps
> should
> wait till next update.
>

Thanks for this. Have never worked with DISTVERSION before, but will recall
for future
commits!


>
> >  MAINTAINER=    g.veniamin at googlemail.com
> >  COMMENT=       Tabbed PDF viewer using the poppler library
> > @@ -18,7 +15,7 @@ LICENSE=      GPLv2
> >  LIB_DEPENDS=   poppler-qt4:${PORTSDIR}/graphics/poppler-qt4 \
> >                 cups:${PORTSDIR}/print/cups-client
> >
> > -USE_QT4=       corelib dbus gui moc_build qmake_build svg xml
> > +USE_QT4=       corelib dbus gui moc_build qmake_build rcc sql svg xml
>
> Some Qt4 components are used only at build stage, rcc is among them. You
> can
> set _build suffix to avoid run dependence on it.
>
>
Good to know. Thanks!

-jgh